Skip to content

ngtests: improve _assert* methods #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sechkova opened this issue Nov 9, 2021 · 0 comments
Open

ngtests: improve _assert* methods #1669

sechkova opened this issue Nov 9, 2021 · 0 comments
Assignees
Labels
backlog Issues to address with priority for current development goals testing

Comments

@sechkova
Copy link
Contributor

sechkova commented Nov 9, 2021

Description of issue or feature request:

Currently #1636 proposes three types of asserts for checking the state of local metadata:

  • _assert_files_exist
  • _assert_content_equals
  • _assert_version_equals

These still have some issues (see #1636 (comment), #1636 (review))

  • non-trivial to pick which assert to use in which test case
  • _assert_content_equals calls the private method Repositorysimulator._fetch_metadata() to get the metadata content in bytes.

A smarter approach is needed, be it integrated in Repositorysimulator or not.

@sechkova sechkova added the backlog Issues to address with priority for current development goals label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals testing
Projects
None yet
Development

No branches or pull requests

2 participants