Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink URL previews #709

Closed
1Phase1 opened this issue Sep 6, 2023 · 3 comments
Closed

Hyperlink URL previews #709

1Phase1 opened this issue Sep 6, 2023 · 3 comments
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@1Phase1
Copy link

1Phase1 commented Sep 6, 2023

Is your feature request related to a problem? Please describe.
As it is now, there's no way to know where a hyperlink leads besides just pressing it to open the link. It might be something you don't want appearing in your browsing history, or you'd just like to have some hint of what the hyperlink leads to before pressing it.

Describe the solution you'd like
A setting to make the top level domain of the URL embedded in a hyperlink visible in parentheses next to the hyperlink itself on comments. That way you can clearly see what site the link leads at a glance.

Describe alternatives you've considered
The only alternative now is pressing hyperlinks and letting them open a tab in your browser to see where they lead.

Additional Context
The following screenshot is an example of this feature as it appeared in Reddit Sync:

Screenshot_20230906_010327

@micahmo
Copy link
Member

micahmo commented Sep 18, 2023

Related to #309.

@micahmo micahmo added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Nov 3, 2023
@micahmo micahmo added this to the v0.2.5 milestone Nov 3, 2023
@micahmo
Copy link
Member

micahmo commented Nov 3, 2023

I'm going to mark this as fixed in an upcoming release due to #869. However, note that the request in the original post was not exactly what was implemented. Rather than showing the domain inline, there is now the ability to preview the link with a long-press. @1Phase1 Feel free to take a look at the screen recording in the PR and let us know if that solution is sufficient. If not, we can revisit your specific request here!

@1Phase1
Copy link
Author

1Phase1 commented Nov 5, 2023

@micahmo I looked at the screen recording for the PR and I'm satisfied with the solution. Seems to be just fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants