-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Can geom_abline() draw lines a bit longer than the actual Coord range? #4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think both layers should calculate the lines on a very expanded scale to avoid this. Both layers are scale-less and this should be reflected in the look |
Just a thought, if somebody wants to tackle this: It may be necessary to make expansion configurable, in case somebody wants to draw an abline but turn off clipping. Expansion could also cause weird effects in nonlinear coordinate systems. |
Hmm... so this is a bit more involved than how it looks on the outside, at least for It is easier for I propose we fix this for |
Someone told me
geom_abline()
doesn't look nice when we increase thesize
. To be fair,geom_function()
seems better at the first example, but it has the same problem when the range of the scale is shorter or equal to the coord's range. I think this is intentional, but it might be nice if there's some option to draw lines to outside of the plot area.(Btw, maybe this is a good chance to replace
GeomAbline
withGeomFunction
...?)Created on 2020-05-24 by the reprex package (v0.3.0)
Created on 2020-05-24 by the reprex package (v0.3.0)
The text was updated successfully, but these errors were encountered: