-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add tests for values, limits, and breaks in manual scale #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for values, limits, and breaks in manual scale #4547
Conversation
* issue introduced in tidyverse#4471 * potential solution for tidyverse#4534 and tidyverse#4511 * add extra tests
I would very much like so. Probably a nice option to add legend items not present in the data if the plot is part of a series, or e.g. to make it obvious that a |
@banfai Would you mind tweaking this pull request to contain only the tests? These are helpful to check if #4619 does the right thing, and, what's more important, I'd like to make it clear that you are a contributor by merging this. The CI checks will of course fail, but it's fine. If you don't have time, I can do it. |
Hi @yutannihilation @teunbrand Thanks for having a look at this. I have seen @teunbrand 's comment earlier on 4511 and agreed that it was a leaner solution, but haven't had time to look deeper or change this PR. |
Thank you! |
Issue introduced in #4471, if there are extra named values in a manual scale then they will show up on the legend even with
drop = TRUE
.Question: should these values be forced with
drop = FALSE
? (currently it's possible)