Skip to content

Commit 5983f40

Browse files
sudohainguyenachals
authored andcommitted
fix: improve parsing bytewax job status
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
1 parent 9cf9d96 commit 5983f40

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_job.py

+16-7
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,22 @@ def status(self):
3535
if job_status.active is not None:
3636
if job_status.completion_time is None:
3737
return MaterializationJobStatus.RUNNING
38-
elif job_status.failed is not None:
39-
self._error = Exception(f"Job {self.job_id()} failed")
40-
return MaterializationJobStatus.ERROR
41-
elif job_status.active is None:
42-
if job_status.completion_time is not None:
43-
if job_status.conditions[0].type == "Complete":
44-
return MaterializationJobStatus.SUCCEEDED
38+
else:
39+
if (
40+
job_status.completion_time is not None
41+
and job_status.conditions[0].type == "Complete"
42+
):
43+
return MaterializationJobStatus.SUCCEEDED
44+
45+
if (
46+
job_status.conditions is not None
47+
and job_status.conditions[0].type == "Failed"
48+
):
49+
self._error = Exception(
50+
f"Job {self.job_id()} failed with reason: "
51+
f"{job_status.conditions[0].message}"
52+
)
53+
return MaterializationJobStatus.ERROR
4554
return MaterializationJobStatus.WAITING
4655

4756
def should_be_retried(self):

0 commit comments

Comments
 (0)