Skip to content

Hitting return mid-node copies contents instead of moving #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taramk opened this issue Feb 16, 2023 · 2 comments
Closed

Hitting return mid-node copies contents instead of moving #17

taramk opened this issue Feb 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@taramk
Copy link
Contributor

taramk commented Feb 16, 2023

http://recordit.co/zDF3X2MlCe

to repro:

put your cursor in the middle of a node with some text
hit return
the contents after the cursor are copied to a new node below, but they also stay with the existing node. the contents should be moved to the new node, not copied.

@taramk taramk added the bug Something isn't working label Feb 16, 2023
@progrium progrium added this to the Announce milestone Feb 21, 2023
@taramk
Copy link
Contributor Author

taramk commented Feb 21, 2023

@progrium - did you test this out...? now when i hit return mid-node it moves the text properly but it leaves an extra newline on the top node.

It goes away if I refresh the page. Tested in Chrome.

http://recordit.co/1bO7FRQFPF

@taramk taramk reopened this Feb 21, 2023
@progrium
Copy link
Contributor

I did not test it with multiline nodes. The height calculation needs to be triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants