Skip to content

Commit 09077bc

Browse files
nikita-youshpcercuei
authored andcommitted
drm/bridge_connector: enable HPD by default if supported
Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() get ignored unless somebody calls drm_bridge_hpd_enable(). When the connector for the bridge is bridge_connector, such a call is done from drm_bridge_connector_enable_hpd(). However drm_bridge_connector_enable_hpd() is never called on init paths, documentation suggests that it is intended for suspend/resume paths. In result, once encoders are switched to bridge_connector, bridge-detected HPD stops working. This patch adds a call to that API on init path. This fixes HDMI HPD with rcar-du + adv7513 case when adv7513 reports HPD events via interrupts. Fixes: c24110a ("drm: rcar-du: Use drm_bridge_connector_init() helper") Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Signed-off-by: Paul Cercueil <paul@crapouillou.net> Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211225063151.2110878-1-nikita.yoush@cogentembedded.com
1 parent fc3785f commit 09077bc

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/drm_bridge_connector.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,10 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
384384
connector_type, ddc);
385385
drm_connector_helper_add(connector, &drm_bridge_connector_helper_funcs);
386386

387-
if (bridge_connector->bridge_hpd)
387+
if (bridge_connector->bridge_hpd) {
388388
connector->polled = DRM_CONNECTOR_POLL_HPD;
389+
drm_bridge_connector_enable_hpd(connector);
390+
}
389391
else if (bridge_connector->bridge_detect)
390392
connector->polled = DRM_CONNECTOR_POLL_CONNECT
391393
| DRM_CONNECTOR_POLL_DISCONNECT;

0 commit comments

Comments
 (0)