Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins using td-rs-derive-py forced to depend on td-rs-chop #13

Closed
rosofo opened this issue Nov 22, 2024 · 2 comments
Closed

Plugins using td-rs-derive-py forced to depend on td-rs-chop #13

rosofo opened this issue Nov 22, 2024 · 2 comments

Comments

@rosofo
Copy link
Contributor

rosofo commented Nov 22, 2024

Guessing this is the lack of hygiene in macros at work: Compiler complains about the use of undeclared module td_rs_chop when trying to derive PyOp.

Workaround: adding td-rs-chop = { path = "../../../td-rs-chop", features = ["python"] } to the plugin fixes it

@rosofo
Copy link
Contributor Author

rosofo commented Nov 22, 2024

@tychedelia
Copy link
Owner

Yeah, this is a bad design, basically wanted to avoid having to import both base + the op type libs, but that means we have to re-export base through the op type. Probably worth just spinning this out and requiring both or finding some other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants