Skip to content

Commit d78d98b

Browse files
fix(eslint-plugin): [no-floating-promises] revert disable of ignoreVoid in strict config (#8718)
* fix(eslint-plugin): [no-floating-promises] revert disable of ignoreVoid in strict config * Reverted inlines too * yarn generate-configs
1 parent 4f44fbc commit d78d98b

File tree

8 files changed

+8
-19
lines changed

8 files changed

+8
-19
lines changed

packages/eslint-plugin/src/configs/strict-type-checked-only.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export = {
1515
'@typescript-eslint/no-base-to-string': 'error',
1616
'@typescript-eslint/no-confusing-void-expression': 'error',
1717
'@typescript-eslint/no-duplicate-type-constituents': 'error',
18-
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: false }],
18+
'@typescript-eslint/no-floating-promises': 'error',
1919
'@typescript-eslint/no-for-in-array': 'error',
2020
'no-implied-eval': 'off',
2121
'@typescript-eslint/no-implied-eval': 'error',

packages/eslint-plugin/src/configs/strict-type-checked.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export = {
2727
'@typescript-eslint/no-explicit-any': 'error',
2828
'@typescript-eslint/no-extra-non-null-assertion': 'error',
2929
'@typescript-eslint/no-extraneous-class': 'error',
30-
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: false }],
30+
'@typescript-eslint/no-floating-promises': 'error',
3131
'@typescript-eslint/no-for-in-array': 'error',
3232
'no-implied-eval': 'off',
3333
'@typescript-eslint/no-implied-eval': 'error',

packages/eslint-plugin/src/rules/no-floating-promises.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,7 @@ export default createRule<Options, MessageId>({
5050
docs: {
5151
description:
5252
'Require Promise-like statements to be handled appropriately',
53-
recommended: {
54-
recommended: true,
55-
strict: [{ ignoreVoid: false }],
56-
},
53+
recommended: 'recommended',
5754
requiresTypeChecking: true,
5855
},
5956
hasSuggestions: true,

packages/repo-tools/src/postinstall.mts

+1-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ if (process.env.SKIP_POSTINSTALL) {
2020
process.exit(0);
2121
}
2222

23-
// eslint-disable-next-line @typescript-eslint/no-floating-promises
24-
(async function (): Promise<void> {
23+
void (async function (): Promise<void> {
2524
// make sure we're running from the workspace root
2625
const {
2726
default: { workspaceRoot },

packages/rule-tester/src/utils/config-validator.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ function validateRuleSchema(
7878
const validateRule = ruleValidators.get(rule);
7979

8080
if (validateRule) {
81-
// eslint-disable-next-line @typescript-eslint/no-floating-promises
82-
validateRule(localOptions);
81+
void validateRule(localOptions);
8382
if (validateRule.errors) {
8483
throw new Error(
8584
validateRule.errors

packages/typescript-eslint/src/configs/strict-type-checked-only.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ export default (
2323
'@typescript-eslint/no-base-to-string': 'error',
2424
'@typescript-eslint/no-confusing-void-expression': 'error',
2525
'@typescript-eslint/no-duplicate-type-constituents': 'error',
26-
'@typescript-eslint/no-floating-promises': [
27-
'error',
28-
{ ignoreVoid: false },
29-
],
26+
'@typescript-eslint/no-floating-promises': 'error',
3027
'@typescript-eslint/no-for-in-array': 'error',
3128
'no-implied-eval': 'off',
3229
'@typescript-eslint/no-implied-eval': 'error',

packages/typescript-eslint/src/configs/strict-type-checked.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ export default (
3535
'@typescript-eslint/no-explicit-any': 'error',
3636
'@typescript-eslint/no-extra-non-null-assertion': 'error',
3737
'@typescript-eslint/no-extraneous-class': 'error',
38-
'@typescript-eslint/no-floating-promises': [
39-
'error',
40-
{ ignoreVoid: false },
41-
],
38+
'@typescript-eslint/no-floating-promises': 'error',
4239
'@typescript-eslint/no-for-in-array': 'error',
4340
'no-implied-eval': 'off',
4441
'@typescript-eslint/no-implied-eval': 'error',

packages/website/src/hooks/useClipboard.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export function useClipboard(code: () => string): useClipboardResult {
99

1010
const copy = useCallback(() => {
1111
// eslint-disable-next-line @typescript-eslint/no-floating-promises
12-
navigator.clipboard.writeText(code()).then(() => {
12+
void navigator.clipboard.writeText(code()).then(() => {
1313
setCopied(true);
1414
});
1515
}, [setCopied, code]);

0 commit comments

Comments
 (0)