Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectConfig failover not working as expected #89

Open
ddukki opened this issue Jan 24, 2025 · 3 comments
Open

ConnectConfig failover not working as expected #89

ddukki opened this issue Jan 24, 2025 · 3 comments

Comments

@ddukki
Copy link

ddukki commented Jan 24, 2025

It looks like ConnectConfig is not working as intended, according to the comment doc. If any of the addresses are not resolved, the whole list fails immediately, even before connections/auth are attempted.

A suggestion might be to update the list with only those that resolve, instead of erroring out? I'll defer on the actual solution here.

@vahid-sohrabloo
Copy link
Owner

I agree. I was using the pgx at that time.
I have to update it.
But I want to add this on v3.
version 3 is close to release. maybe in 2 or 3 weeks.

@ddukki
Copy link
Author

ddukki commented Jan 24, 2025

Excited for v3, but wondering if there are significant changes to the codebase involved there? v2 seems very stable and I'm worried about possible refactoring issues/overhead. Any chance of pulling this particular change in to v2?

@vahid-sohrabloo
Copy link
Owner

I want to finish the v3 first. after that, I can add it.
By the way, feel free to make a PR for this if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants