Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When seeking over an interstitial, resume the primary content at the original seek target time after it ends. #7029

Open
matvp91 opened this issue Feb 17, 2025 · 1 comment

Comments

@matvp91
Copy link
Collaborator

matvp91 commented Feb 17, 2025

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

As discussed earlier, seeking over an interstitial should maintain the original seek target when returning to primary. The RESUME-OFFSET shall be ignored.

Additional context

N/A

@matvp91 matvp91 added Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Feb 17, 2025
@robwalch robwalch removed the Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. label Feb 20, 2025
@robwalch
Copy link
Collaborator

The interstitial-controller has a shouldPlay state flag used to resume playback after source resets. I suppose a similar seekTarget could be maintained when a seek is issued and interrupted by interstitial playback. This target could then be used when resuming primary after the seek interrupting break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants