New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should apply model.norm layer to hidden_states[early_exit_layer] ? #9

Open

githubhyz opened this issue Nov 16, 2023 · 1 comment

githubhyz commented Nov 16, 2023 •

edited

Loading

DoLa/transformers-4.28.1/src/transformers/models/llama/modeling_llama.py

Line 703 in dc88907

logits = self.lm_head(outputs.hidden_states[early_exit_layer])

I think you guys should apply model.norm layer to hidden_states[early_exit_layer] . Because only the last hidden_state applied model.norm layer. See

DoLa/transformers-4.28.1/src/transformers/models/llama/modeling_llama.py

Line 594 in dc88907

hidden_states = self.norm(hidden_states)

pphuc25 commented Dec 21, 2023

This makes sense, but when apply your suggestion, the accuracy go down in GSM8k dataset, have no idea why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment