Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioDecoderConfig.numberOfChannels and AudioDecoderConfig.sampleRate should be explicitly forbidden to be 0 #878

Open
jyavenard opened this issue Feb 3, 2025 · 0 comments

Comments

@jyavenard
Copy link
Member

Similar to #860

Currently the specs only consider an AudioDecoderConfig as invalid if

1. If codec is empty after stripping leading and trailing ASCII whitespace, return false.
2. If description is [detached], return false.
3. Return true.

It should be:

1. If codec is empty after stripping leading and trailing ASCII whitespace, return false.
2. If description is [detached], return false.
3. If sampleRate or numberOfChannels are equal to zero, return false.
4. Return true.
@jyavenard jyavenard changed the title AudioDecoderConfig.channels and AudioDecoderConfig.sampleRate should be explicitly forbidden to be 0 AudioDecoderConfig.numberOfChannels and AudioDecoderConfig.sampleRate should be explicitly forbidden to be 0 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant