-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Cannot change the default value of the batch request timeout #6190
Comments
@Muhammad-Altabba can you assign it to me? |
@sleepyqadir anything new sir? |
Hi @sleepyqadir any update to the issue ? |
Hi @Muhammad-Altabba I kindly request your permission to proceed with this issue and contribute to the project's improvement. If there are any specific instructions or considerations I should be aware of, please let me know. Thank you for your time and consideration. I look forward to your response. |
Adding this option isn't difficult, but how the hell do you build this project? I even get errors on yarn install and I don’t intend to go through 14 circles of hell (checklist) for the sake of this garbage. Who needs my solution - here is https://github.com/newTomas/web3.js/tree/patch-1 |
@shubhamshd |
Hi @shubhamshd , |
Thanks @newTomas @Muhammad-Altabba will work on it this weekend |
Hi @Muhammad-Altabba @newTomas I was planning to introduce a private property in the Web3BatchRequest class and initiate it via constructor, something similar as follows : ` private _defaultBatchRequestTimeout: number; // Add this line public constructor( But that would need subsequent changes at all places where this Web3BatchRequest object is called/initialized right? is this something fine or am I making it complex? |
@shubhamshd |
Hi @Muhammad-Altabba @newTomas It took some time to understand the web3batchrequest class and its usage, and definitely the solution suggested by @newTomas looks promising to me!!! I have opened a pr with the required change, please review and let me know, if any changes required!!! thanks both :) |
Is the problem still unresolved? I don't see this code in the source code, my version is "^4.6.0" |
The constant existed at
https://github.com/ChainSafe/web3.js/blob/ab8013101665d687cb140fee2c1f528b5eec562b/packages/web3-core/src/web3_batch_request.ts#L23:
Is used without the possibility to change it:
Environment
web3.js version 4.x
The text was updated successfully, but these errors were encountered: