Skip to content

Possible regression in #182 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swissspidy opened this issue Mar 5, 2025 · 2 comments · Fixed by #184
Closed

Possible regression in #182 #183

swissspidy opened this issue Mar 5, 2025 · 2 comments · Fixed by #184

Comments

@swissspidy
Copy link
Member

Possible regression(s) added in #182 / #181 / #179 as I see some test failures.

db-command

Failure: https://github.com/wp-cli/db-command/actions/runs/13666781256/job/38218892103#step:11:58

Test: https://github.com/wp-cli/db-command/blob/e9c4e8ab61e99f7fa7e31e584c2b2b5d54d071db/features/db-columns.feature#L44-L52

Output:

$ wp db columns not_wp
+---------------+------+------+-----+---------+-------+
| Field         | Type | Null | Key | Default | Extra |
+---------------+------+------+-----+---------+-------+
| date          | date | NO   | PRI |         |       |
| awesome_stuff | text | YES  |     |         |       |
+---------------+------+------+-----+---------+-------+

$ wp db columns not_wp | cat
Field	Type	Null	Key	Default	Extra
date	date	NO	PRI		
awesome_stuff	text	YES

find-command

Failure: https://github.com/wp-cli/find-command/actions/runs/13666779769/job/38218964304#step:11:31

Test: https://github.com/wp-cli/find-command/blob/1487101a1bf3ed76b627b09790617ea470ad6a20/features/find.feature#L175-L179

search-replace-command

Failure: https://github.com/wp-cli/search-replace-command/actions/runs/13666792912/job/38219000957#step:11:65

Test: https://github.com/wp-cli/search-replace-command/blob/892570e343b8949e0643e6b12cb20dd92816852e/features/search-replace.feature#L671-L674

entity-command

Failures: https://github.com/wp-cli/entity-command/actions/runs/13666762683/job/38218928926#step:11:143

Here some tests probably need updating because of the line breaks. But others look like regressions from here.

@swissspidy
Copy link
Member Author

cc @mrsdizzie

@mrsdizzie
Copy link
Member

🤦‍♀️

For helpful reference, I was able to see this with cat -A:

#Broken:
wp db columns not_wp | cat -A
Field^IType^INull^IKey^IDefault^IExtra$
date^Idate^INO^IPRI$
awesome_stuff^Itext^IYES$

#Working
wp db columns not_wp | cat -A
Field^IType^INull^IKey^IDefault^IExtra$
date^Idate^INO^IPRI^I^I$
awesome_stuff^Itext^IYES^I^I^I$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants