Skip to content

Commit c0753b9

Browse files
authored
Merge pull request #18 from wwt/certified_update
bugfix to support cisco.meraki version 2.18.1
2 parents 8506de3 + e75a913 commit c0753b9

File tree

5 files changed

+25
-13
lines changed

5 files changed

+25
-13
lines changed

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,4 +162,4 @@ scratch/
162162
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
163163
#.idea/
164164

165-
changelogs/.plugin_cache.yaml
165+
changelogs/.plugin-cache.yaml

CHANGELOG.md

+12-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22

33
**Topics**
44

5+
- <a href="#v1-1-3">v1\.1\.3</a>
6+
- <a href="#bugfixes">Bugfixes</a>
57
- <a href="#v1-1-2">v1\.1\.2</a>
68
- <a href="#breaking-changes--porting-guide">Breaking Changes / Porting Guide</a>
7-
- <a href="#bugfixes">Bugfixes</a>
9+
- <a href="#bugfixes-1">Bugfixes</a>
810
- <a href="#v1-1-1">v1\.1\.1</a>
911
- <a href="#minor-changes">Minor Changes</a>
1012
- <a href="#breaking-changes--porting-guide-1">Breaking Changes / Porting Guide</a>
@@ -13,6 +15,14 @@
1315
- <a href="#new-plugins">New Plugins</a>
1416
- <a href="#lookup">Lookup</a>
1517

18+
<a id="v1-1-3"></a>
19+
## v1\.1\.3
20+
21+
<a id="bugfixes"></a>
22+
### Bugfixes
23+
24+
* configure\_meraki\_mx \- Fixed VLAN provisioning to match requirements with cisco\.meraki collection version 2\.18\.1
25+
1626
<a id="v1-1-2"></a>
1727
## v1\.1\.2
1828

@@ -21,7 +31,7 @@
2131

2232
* manage\_meraki\_network \- updated data model so that tags are now a list
2333

24-
<a id="bugfixes"></a>
34+
<a id="bugfixes-1"></a>
2535
### Bugfixes
2636

2737
* configure\_meraki\_mt \- fixed conditional preventing lookup dictionary creation

changelogs/changelog.yaml

+8
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,11 @@ releases:
4242
- v1.1.2-breaking.yaml
4343
- v1.1.2-bugfixes.yaml
4444
release_date: '2024-05-31'
45+
1.1.3:
46+
changes:
47+
bugfixes:
48+
- configure_meraki_mx - Fixed VLAN provisioning to match requirements with cisco.meraki
49+
collection version 2.18.1
50+
fragments:
51+
- v1.1.3-bugfixes.yaml
52+
release_date: '2024-05-31'

galaxy.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace: wwt
99
name: meraki
1010

1111
# The version of the collection. Must be compatible with semantic versioning
12-
version: 1.1.2
12+
version: 1.1.3
1313

1414
# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
1515
readme: README.md
@@ -44,7 +44,7 @@ tags:
4444
# collection label 'namespace.name'. The value is a version range
4545
# L(specifiers,https://python-semanticversion.readthedocs.io/en/latest/#requirement-specification). Multiple version
4646
# range specifiers can be set and are separated by ','
47-
dependencies: { cisco.meraki: ">=2.18.0" }
47+
dependencies: { cisco.meraki: ">=2.18.1" }
4848
# The URL of the originating SCM repository
4949
repository: https://github.com/wwt/meraki_collection
5050

roles/configure_meraki_mx/tasks/configure_vlans.yml

+2-8
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616

1717
#
1818
# First pass configuration throws the following errors when run
19-
# when vlanId parameter is omitted:
20-
# Error: Appliance.getNetworkApplianceVlan() missing 1 required positional argument: 'vlanId'
21-
#
22-
# When vlanId parameter is present:
23-
# Error: An error occured when executing operation.
2419
# The error was: appliance, getNetworkApplianceVlan - 404 Not Found, please wait a minute if the key or org was just newly created.
2520
#
2621
# VLANs are provisioned correctly regardless of error as noted above
@@ -32,7 +27,6 @@
3227
state: "{{ vlan.state }}"
3328
networkId: "{{ network_id }}"
3429
id: "{{ vlan.id }}"
35-
vlanId: "{{ vlan.id }}"
3630
name: "{{ vlan.name | default(omit) }}"
3731
subnet: "{{ vlan.subnet | default(omit) }}"
3832
applianceIp: "{{ vlan.appliance_ip | default(omit) }}"
@@ -46,7 +40,7 @@
4640
meraki_api_key: "{{ auth_key }}"
4741
state: "{{ vlan.state }}"
4842
networkId: "{{ network_id }}"
49-
vlanId: "{{ vlan.id }}"
43+
id: "{{ vlan.id }}"
5044
name: "{{ vlan.name | default(omit) }}"
5145
reservedIpRanges: "{{ vlan.reserved_ip_range | default(omit) }}"
5246
fixedIpAssignments: "{{ vlan.fixed_ip_assignments | default(omit) }}"
@@ -66,7 +60,7 @@
6660
meraki_api_key: "{{ auth_key }}"
6761
state: "{{ vlan.state }}"
6862
networkId: "{{ network_id }}"
69-
vlanId: "{{ vlan.id }}"
63+
id: "{{ vlan.id }}"
7064
name: "{{ vlan.name | default(omit) }}"
7165
subnet: "{{ vlan.subnet | default(omit) }}"
7266
applianceIp: "{{ vlan.appliance_ip | default(omit) }}"

0 commit comments

Comments
 (0)