Skip to content

Commit 83a0c6e

Browse files
gobenjiJeff Kirsher
authored and
Jeff Kirsher
committed
i40e: Invoke softirqs after napi_reschedule
The following message is logged from time to time when using i40e: NOHZ: local_softirq_pending 08 i40e may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame. The problem is the same as what was described in commit ec13ee8 ("virtio_net: invoke softirqs after __napi_schedule") and this patch applies the same fix to i40e. Signed-off-by: Benjamin Poirier <bpoirier@suse.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent ee847d9 commit 83a0c6e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/intel/i40e/i40e_main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4685,8 +4685,10 @@ static void i40e_detect_recover_hung_queue(int q_idx, struct i40e_vsi *vsi)
46854685
*/
46864686
if ((!tx_pending_hw) && i40e_get_tx_pending(tx_ring, true) &&
46874687
(!(val & I40E_PFINT_DYN_CTLN_INTENA_MASK))) {
4688+
local_bh_disable();
46884689
if (napi_reschedule(&tx_ring->q_vector->napi))
46894690
tx_ring->tx_stats.tx_lost_interrupt++;
4691+
local_bh_enable();
46904692
}
46914693
}
46924694

0 commit comments

Comments
 (0)