Skip to content

Commit efcc32c

Browse files
authoredJun 20, 2021
fix(string-utils): detect [0,1] ranged values as numbers (#388)
1 parent 49cf368 commit efcc32c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed
 

‎lib/string-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@ export function looksLikeNumber (x: null | undefined | number | string): boolean
5858
// hexadecimal.
5959
if (/^0x[0-9a-f]+$/i.test(x)) return true
6060
// don't treat 0123 as a number; as it drops the leading '0'.
61-
if (x.length > 1 && x[0] === '0') return false
61+
if (/^0[^.]/.test(x)) return false
6262
return /^[-]?(?:\d+(?:\.\d*)?|\.\d+)(e[-+]?\d+)?$/.test(x)
6363
}

‎test/string-utils.cjs

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,11 @@ describe('string-utils', function () {
2727
it('it detects strings that could be parsed as numbers', () => {
2828
strictEqual(looksLikeNumber('3293'), true)
2929
strictEqual(looksLikeNumber('0x10'), true)
30-
strictEqual(looksLikeNumber('0x10'), true)
30+
strictEqual(looksLikeNumber('.1'), true)
31+
strictEqual(looksLikeNumber('0.1'), true)
32+
strictEqual(looksLikeNumber('0.10'), true)
3133

34+
strictEqual(looksLikeNumber('00.1'), false)
3235
strictEqual(looksLikeNumber('0100'), false)
3336
strictEqual(looksLikeNumber('apple'), false)
3437
})

0 commit comments

Comments
 (0)
Please sign in to comment.