Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if lstat fails on metadata #486

Closed
TypicalAM opened this issue Nov 24, 2024 · 0 comments · Fixed by #532
Closed

Crash if lstat fails on metadata #486

TypicalAM opened this issue Nov 24, 2024 · 0 comments · Fixed by #532
Labels
bug Something isn't working

Comments

@TypicalAM
Copy link

superfile panics when viewing folder metadata if lstat on a file fails. Steps to reproduce:

  • go install github.com/yorukot/superfile@latest
  • cd $(mkdir -d)
  • mkdir dir
  • echo test > dir/testfile
  • chmod 666 dir # Taking away the execute bit on a folder makes the user unable to get the size of its contents
  • superfile # Press m
2024/11/24 21:22:40 Dir size function error
2024/11/24 21:22:40 lstat /tmp/tmp.uTY7qe519s/dir/testfile: permission denied

Mangled panic trace since it also destroyed my terminal window:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic when trying to get folder size without needed permissions GRFreire/superfile
1 participant
@TypicalAM