Skip to content

[v3] consider using position only and keyword only arguments #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshmoore opened this issue May 4, 2022 · 3 comments · Fixed by #1884
Closed

[v3] consider using position only and keyword only arguments #1019

joshmoore opened this issue May 4, 2022 · 3 comments · Fixed by #1884
Labels
design discussion help wanted Issue could use help from someone with familiarity on the topic
Milestone

Comments

@joshmoore
Copy link
Member

As a side note we might consider using position only and keyword only arguments in Zarr 3 to avoid these issues around renaming arguments.

Originally posted by @jakirkham in #1018 (comment)

@joshmoore joshmoore added the help wanted Issue could use help from someone with familiarity on the topic label Dec 2, 2022
@jhamman jhamman added the V3 label Dec 7, 2023
@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 Apr 5, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
@jhamman jhamman changed the title v3: consider using position only and keyword only arguments [v3] consider using position only and keyword only arguments Apr 5, 2024
@jhamman
Copy link
Member

jhamman commented Apr 5, 2024

@jakirkham and @joshmoore - would either of you care to expand on this issue to make it more actionable?

@joshmoore
Copy link
Member Author

My limited memory, @jhamman, is that for signatures with very long lists of arguments, maintaining the ordering of those lists becomes a burden and therefore one can make use of keyword only arguments -- https://peps.python.org/pep-3102/ -- to simplify things.

@jhamman
Copy link
Member

jhamman commented May 17, 2024

My first attempt at recreating the top level API for v3 definitely highlighted that this would be useful. I could use some input on #1884 deciding how best to introduce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design discussion help wanted Issue could use help from someone with familiarity on the topic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants