Skip to content

[v3] Deprecate stores that we don't expect to include in v3 #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
jhamman opened this issue Apr 5, 2024 · 4 comments · Fixed by #1801
Closed
4 tasks

[v3] Deprecate stores that we don't expect to include in v3 #1756

jhamman opened this issue Apr 5, 2024 · 4 comments · Fixed by #1801
Assignees
Milestone

Comments

@jhamman
Copy link
Member

jhamman commented Apr 5, 2024

Following #1274, we expect the v3 release to include a smaller subset of stores. Specifically:

  • MemoryStore
  • DirectoryStore
  • ZipFileStore
  • FsspecStore

The thought is to move everything else to another library or, deprecate entirely.

As a first step, we should mark stores that we expect to move out of this library as deprecated and provide a discussion issue where we can direct users of those stores to.

TODOs here:

  • deprecate existing stores
  • open discussion issue
  • make at least one Zarr-Python release ahead of the 3.0 release with this deprecation warning
  • last step, remove existing stores
@jhamman jhamman added the V3 label Apr 5, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
@jhamman jhamman self-assigned this Apr 5, 2024
@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 Apr 5, 2024
@jhamman jhamman modified the milestones: 3.0.0.alpha, 2.18.0 Apr 6, 2024
@d-v-b
Copy link
Contributor

d-v-b commented Apr 17, 2024

this is happening in #1791

@joshmoore
Copy link
Member

Thanks for pushing this, guys. I find it unfortunate that the stores weren't in their own modules since I'd very much for keeping their git history. I'd be inclined even with the mega module to use a filter branch to populate the new repositories.

@jhamman
Copy link
Member Author

jhamman commented Apr 19, 2024

Thanks for pushing this, guys. I find it unfortunate that the stores weren't in their own modules since I'd very much for keeping their git history. I'd be inclined even with the mega module to use a filter branch to populate the new repositories.

@joshmoore - its not too late to do this. I'd fully support someone taking this on.

@joshmoore
Copy link
Member

it's not too late to do this.

definitely! 👍

@jhamman jhamman moved this from Todo to In Progress in Zarr-Python - 3.0 Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Zarr-Python - 3.0 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants