Skip to content

sharding codec use of lru caching fails with numpy void scalars #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
d-v-b opened this issue May 13, 2025 · 0 comments
Open

sharding codec use of lru caching fails with numpy void scalars #3054

d-v-b opened this issue May 13, 2025 · 0 comments

Comments

@d-v-b
Copy link
Contributor

d-v-b commented May 13, 2025

numpy void scalars are not hashable, which means that a class with a np.void attribute cannot be hashed by lru_cache, which is used by the sharding codec class here.

I ran into this In #2874. Any ideas for fixing this would be appreciated! IMO the ideal fix would be to resolve the basic performance problems we are solving with this caching layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-v-b