Fix/auth response in submit #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveroga
approved these changes
May 27, 2025
| @@ -45,10 +52,21 @@ export type ContractInvokeTransactionData = { | |||
| network?: string; | |||
| }; | |||
|
|
|||
| export type AuthProofEthIdentity = { | |||
| userDid: DID; | |||
There was a problem hiding this comment.
Any convention about when to use userDid or userDID ? userDid when it's a property of object type and userDID for function params and variables?
daveroga
reviewed
May 28, 2025
| @@ -174,7 +177,7 @@ describe('contract-request', () => { | |||
| }, | |||
|
|
|||
| prepareTxArgsSubmit: async () => { | |||
| return []; | |||
| return {} as any; | |||
There was a problem hiding this comment.
lint warning. Maybe explicit disable line no-explicit-any
vmidyllic
added a commit
that referenced
this pull request
May 28, 2025
* fix cross chain proofs and calc auth challenge * add cross chain proof for auth response and integration test * Fix/auth response in submit (#314) * refactor usage of auth proofs --------- Co-authored-by: GopherDID <74898029+vmidyllic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.