Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Ordinal" property #11

Closed
OmegaExtern opened this issue Sep 22, 2016 · 4 comments
Closed

Add "Ordinal" property #11

OmegaExtern opened this issue Sep 22, 2016 · 4 comments
Labels
enhancement
Milestone
v1.4

Comments

@OmegaExtern
Copy link

So, it would allow to export methods at desired ordinal.
@3F 3F added the duplicate label Sep 23, 2016
@3F
Copy link
Owner

3F commented Sep 23, 2016

seems dup of #8

@3F 3F closed this as completed Sep 23, 2016
@OmegaExtern
Copy link
Author

seems dup of #8

Not duplicate.
#8 is to mimic ordinal counter to start from 1 instead of 0 (by default), and nothing more.
While this proposes to add a new property to DllExportAttribute class, which would allow to override the counter number.

@3F
Copy link
Owner

3F commented Sep 23, 2016 •
edited
Loading

initially it was a 'Ordinals should start from one (1), not zero (0)' with unclear description of what you trying to solve -_-

ok, suggestion to start from 1+ there, and to add as a common solution here

@3F 3F reopened this Sep 23, 2016
@3F 3F added enhancement and removed duplicate labels Sep 23, 2016
3F added a commit that referenced this issue Sep 30, 2016
@3F
Started new GUI Configurator
ba0da45 
related issues: #8, #9, #11, #14
3F added a commit that referenced this issue Oct 1, 2016
@3F
Implemented feature 'Base for ordinals' #11
a2e9ba6 
The one (1) now is used by default as Base for all ordinals #8

There is also alternative to configure this number - MSBuild property: DllExportOrdinalsBase
@3F
Copy link
Owner

3F commented Oct 1, 2016

mod_ordinals

you can check it with a2e9ba6

@3F 3F added this to the v1.4 milestone Oct 1, 2016
@3F 3F closed this as completed Oct 4, 2016
3F added a commit that referenced this issue Oct 5, 2016
@3F
public release v1.4
c637152 
    * FIXED: Fixed bug - `An item with the same key has already been added`. Issue #10
    * FIXED: Bug with Meta library: Incorrect default values. Issue #16
             please note, the __cdecl is the default calling convention for our library
             as and for C and C++ programs.

    * FIXED?: Probably fixed bug - `Script errors on package install` Issue #6
    * FIXED?: Probably fixed bug - `non-English system language - syntax error` Issue #7
    * NEW: GUI Configurator with updated ddNS features.
    * NEW: Implemented feature 'Export for platform': [ x86 / x64 / x86 + x64 ] Issue #9
    * NEW: Implemented feature 'Base for ordinals'. Issue #11
           There is also alternative to configure this number - MSBuild property: DllExportOrdinalsBase

    * NEW: The one (1) now is used by default as Base for all ordinals.
           `Mimic ordinal counter (start from 1 instead of 0)` Issue #8

    * CHANGED: The ddNS features now as binary cmdlet `NSBin`. Use `nsbin.bat` if needed.
    * CHANGED: `Set "Inherited = false" in AttributeUsage for DllExportAttribute`. Issue #15
    * OTHER: other possible changes and fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
2 participants
@3F @OmegaExtern