Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output compare interrupts do not correctly configure clear on output compare. #12

Closed
AJMansfield opened this issue Jun 2, 2019 · 0 comments · Fixed by #14
Closed

Output compare interrupts do not correctly configure clear on output compare. #12

AJMansfield opened this issue Jun 2, 2019 · 0 comments · Fixed by #14
Labels
bug

Comments

@AJMansfield
Copy link
Owner

Split from #11.

Presently the output compare interrupts do not correctly configure the timer peripheral to clear the output pins on a compare match as intended.

TriacDimmer.cpp:100 should read:

	TCCR1A &=~ _BV(COM1A0); //clear OC1x on compare match

and likewise TriacDimmer.cpp:112 should read:

	TCCR1A &=~ _BV(COM1B0); //clear OC1x on compare match

Credit to @JAndrassy for spotting this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure output compare behavior correctly. AJMansfield/TriacDimmer
1 participant
@AJMansfield