[trello.com/c/hzqPFC5l] Update "Send Crypto" screen to use with secret wallets #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
commented
Mar 17, 2025
|
|
||
| $0.value = secretWalletViewModel.state.currentWallet?.name ?? String.localized("SecretWallets.Menu.Regular", comment: "Regular Wallet") | ||
|
|
||
| for wallet in secretWalletManager.getRegularWallet().sorted(includeInvisible: false) where wallet.core.wallet?.address == walletCore.wallet?.address { |
There was a problem hiding this comment.
This view controller is used on two different screens. On the account tab, you can access it by tapping "Send (cryptoTokenName)". In an open chat, you can find it by tapping the plus button and choosing "Transfer Crypto".
Even though the same component is used in both places, the context for secret wallets differs: in the chat, only the regular wallet can be used, whereas on the account tab, it doesn’t matter if the wallet is secret or regular.
My solution is simple:
By default, we show the name from the current wallet (which might be secret). However, if the regular wallet has the same address as the current wallet in the view controller, we change the display name to "Regular Wallet".
Lainaaa
requested review from
art-divin,
ChrisBenua,
just-software-dev,
PingPongEzZ and
vovameister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can find description of the main part in comments.