-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: support gmail & yahoo smtp check by api #88
Conversation
PR in draft status, waitting to add tests and fix CI. |
# hotfix sessionIndex missed issue in new yahoo feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
@OisCircle @lryong I'm not familiar with the email vendor, so not sure if it has any risks in using the signup process to check if the user exists. If yes, I think we should add some comments to notice this. Others are good to me and left one comment inline. |
Since it is not practical to check the existence of email addresses through smtp protocol, we have researched that large free email providers such as gmail and yahoo can check email addresses through relevant API interface methods, so we try to add the ability to check the validity of email addresses here. |
Yes, it sounds good. Need to take care of the risks if plan to use it in production. |
I have added comments to inform the user about the potential risks and related knowledge on abusing. |
Background
Add support of smtp check by api
What's changed