None preset always present and custom value conversion #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
AlePerla
commented
Dec 10, 2022
AlePerla
commented
- "None" preset always added if there are other presets
- Custom values for DP_ECO can have several (bool, int, string) conversions before being sent
…et always added if there are presets (to fix values display during config flow) modified: custom_components/localtuya/__init__.py * no dots in logged lines modified: custom_components/localtuya/climate.py + function to convert value based on selected format * add No preset always if there are other presets modified: custom_components/localtuya/const.py + constants for format and none value modified: custom_components/localtuya/manifest.json * version * codeowners modified: custom_components/localtuya/strings.json modified: custom_components/localtuya/translations/en.json modified: custom_components/localtuya/translations/it.json modified: custom_components/localtuya/translations/pt-BR.json + translations (to be fixed pt-BR)
…et always added if there are presets (to fix values display during config flow) modified: custom_components/localtuya/__init__.py * no dots in logged lines modified: custom_components/localtuya/climate.py + function to convert value based on selected format * add No preset always if there are other presets modified: custom_components/localtuya/const.py + constants for format and none value modified: custom_components/localtuya/manifest.json * version * codeowners modified: custom_components/localtuya/strings.json modified: custom_components/localtuya/translations/en.json modified: custom_components/localtuya/translations/it.json modified: custom_components/localtuya/translations/pt-BR.json + translations (to be fixed pt-BR)
* set of none without return was sending it dobled and with wrong value
* using custom values only when set
…com/AlePerla/localtuya into none_preset_always_value_conversion
AlePerla
pushed a commit
that referenced
this pull request
Feb 4, 2025
…t_registry Fix depreciated async_get_registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.