Skip to content

Kdz: Switch to iscgar's KDZ extractor impl #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kdz: Switch to iscgar's KDZ extractor impl #27

wants to merge 1 commit into from

Conversation

amackpro
Copy link

No description provided.

@deadman96385
Copy link
Contributor

So I tested this new implementation and it doesn't seem to work on the LG Wing kdz where as the original one does work.

Here is the kdz file I was testing against
https://s3.us-east-1.wasabisys.com/filestash-buk/LG/F100TM20c_00_NA2_US_OP_0302.7z

Traceback (most recent call last): File "/home/deadman/dumpyara/Firmware_extractor/tools/unkdz.py", line 716, in <module> main() File "/home/deadman/dumpyara/Firmware_extractor/tools/unkdz.py", line 690, in main dz_hdr = parse_dz_record(in_file, dz_record) File "/home/deadman/dumpyara/Firmware_extractor/tools/unkdz.py", line 590, in parse_dz_record dz_hdr = DzHeader(f) File "/home/deadman/dumpyara/Firmware_extractor/tools/unkdz.py", line 411, in __init__ self.parts = self._parse_v1_part_headers(part_count, file) File "/home/deadman/dumpyara/Firmware_extractor/tools/unkdz.py", line 488, in _parse_v1_part_headers assert all(b == 0 for b in padding), ( AssertionError: non zero bytes in part padding @ index 0

@amackpro
Copy link
Author

https://gist.github.com/iscgar/e0da0868df7b2f179b000c61f12d1a8c/revisions

update and try

@AntoninoScordino AntoninoScordino force-pushed the master branch 11 times, most recently from f9bcf2c to 2e1f12c Compare September 29, 2024 14:06
@AntoninoScordino AntoninoScordino force-pushed the master branch 16 times, most recently from 4214b15 to c62a27d Compare October 12, 2024 16:20
@AntoninoScordino AntoninoScordino force-pushed the master branch 2 times, most recently from ffae245 to 1fb00f8 Compare October 15, 2024 18:40
@AntoninoScordino AntoninoScordino force-pushed the master branch 6 times, most recently from b263b67 to 1209882 Compare November 2, 2024 19:24
@AntoninoScordino AntoninoScordino force-pushed the master branch 3 times, most recently from 9dc1764 to e61ce8a Compare January 11, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amackpro @deadman96385