Skip to content

CRAN notes fixes #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2021
Merged

CRAN notes fixes #171

merged 3 commits into from
Nov 9, 2021

Conversation

jakubsob
Copy link
Contributor

@jakubsob jakubsob commented Nov 9, 2021

Fix CRAN notes:

  • Add vignette builder to DESRIPTION
  • Remove LazyData field from DESCRIPTION
  • Add rmarkdown to Suggests as it's required by a vignette
  • Fix invalid URL's in vignette

@jakubsob
Copy link
Contributor Author

jakubsob commented Nov 9, 2021

CI fails as shiny.semantic binaries are not yet available on CRAN. Package passes R CMD check --as-cran and builds correctly

@jakubsob jakubsob changed the title Cran fixes CRAN notes fixes Nov 9, 2021
@jakubsob jakubsob merged commit 9025bdd into develop Nov 9, 2021
@jakubsob jakubsob deleted the cran-fixes branch November 9, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

@mdubel mdubel Awaiting requested review from mdubel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubsob @jakubnowicki