This repository was archived by the owner on Dec 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] New interfaces for better graph resolution #92
Open
jspahrsummers
wants to merge
29
commits into
master
Choose a base branch
from
graph-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current status (for myself, if no one else):
|
… DFS This is more incremental and extensible, allowing us to implement more advanced strategies like backmarking.
It’s surprising that this function returns a value type instead of a reference, which is what at() does.
9b0059d
to
9f36dbd
Compare
Been heads-down at my day job for the past couple weeks. I hope to return to this over the next couple. |
f21853c
to
8fd36f0
Compare
I don’t think this is taken advantage of anywhere… besides, it seems Bad™.
There's still work to be done, but
|
f75e0d7
to
ff20fcf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WORK IN PROGRESS 🚧
To do:
ArbiterResolvedDependencyGraph
to be a simple value type, and not store requirementsFuture work: