-
Notifications
You must be signed in to change notification settings - Fork 12
test: API Empty TX Object Response #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: API Empty TX Object Response #85
Conversation
- this change also fixes the 'platformio_example' path
This reverts commit d12af6f.
- update API empty transactions Post response. was: "child \"transactions\" fails because [\"transactions\" must contain at least 1 items]" is now: "should NOT have fewer than 1 items"
The ci/circleci: build-linux-default job is failing as of d61f66830daae5f5ae8e5e251f49e171f8206826. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
The ci/circleci: build-linux-default job is failing as of 0e21097b3214ebb3ffc67afacb6531634659e03b. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Test failures are not a result of this PR. This is a PlatformIO/ArduinoJson package issue, and will be resolved like ArkEcosystemArchive/cpp-crypto#76. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should always test for a specific HTTP status code instead of relying on messages because those can always change. In this case you should test for status code 422 in the response.
- also update changelog brief
Thank you, @faustbrian |
Proposed changes
This small PR updates the API Response test when posting an empty transactions objects.
It also updates the changelog.
Response was:
Response is now:
It now tests for "statusCode" '422'
Types of changes
Checklist