test(chore): update ArduinoJson version #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this change also fixes the 'platformio_example' path
This reverts commit d12af6f.
This reverts commit d12af6f.
- update ArduinoJson v.5.13.2 >> v.6.10.1 - update ArduinoJson submodule. - updated PIO.ini ArduinoJson flags (enforce v.6.10.1). - update JSON use patterns in tests. - update Wallets::Top test case. - add ESP8266 & ESP32 WiFi option to test_main.cpp for IoT. - update documentation with changes.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
Complexity: High
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
======================================
Coverage 96.4% 96.4%
======================================
Files 14 14
Lines 250 250
======================================
Hits 241 241
Misses 9 9Continue to review full report at Codecov.
|
- update wallet::top test case. - remove 'loop()' 'delay(x)'.
faustbrian
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates ArduinoJson v.5.13.2 >> v.6.10.1.
Specifically, this PR does the following:
Types of changes
Checklist
Further comments
This PR also resolves failing tests in #85 & #86