-
Notifications
You must be signed in to change notification settings - Fork 12
chore: Update build to be out of source #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update build to be out of source #115
Conversation
Updated build to be out of source to clean up the workspace and added build scripts to enforce this. Re-enabled cmake_example builds in CI. Removed cmake_example .gitmodules file. This historically caused git to do funny things having a nested .gitmodules in the source tree. Commented out the submodule clone in the CMakeList.txt and setup the build script to mimic the submodule clone by copying the cpp-crypto source into the correct directory.
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Updated build and run tests steps for Linux, Mac, and Windows.
…iband/cpp-client into chore/add_out_of_source_builds
Clang tidy is failing and I'm not sure why. There is a lot of noise in the output from curl and what not. I think a future PR to limit clang tidy file processing to not process submodules is needed. We can either merge this PR as is or we can hold until we can reduce the clang tidy output such that the error is easier to spot. |
Update: It appears that clang tidy is failing on a curl source file: Line 63249: Line 177893: I do not know why. |
@ciband conflicts |
@sleepdefic1t , @faustbrian Clang build failure looks like a circle ci issue. I am unable to re-trigger, if desired. |
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Updated build to be out of source to clean up the workspace
and added build scripts to enforce this.
Re-enabled cmake_example builds in CI.
Removed cmake_example .gitmodules file. This historically caused
git to do funny things having a nested .gitmodules in the source
tree. Commented out the submodule clone in the CMakeList.txt and
setup the build script to mimic the submodule clone by copying the
cpp-crypto source into the correct directory.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: