Skip to content

feat: transactions/fees endpoint #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/api/paths.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,17 @@ std::string Transactions::types(Host& newHost) {

/**/

std::string Transactions::fees(Host& newHost) {
std::string url;
url.reserve(URL_MAX_LEN);
url += newHost.toString().c_str();
url += Transactions::base();
url += "/fees";
return url;
}

/**/

std::pair<std::string, std::string> Transactions::search(
Host& newHost,
const std::map<std::string, std::string>& bodyParameters,
Expand Down
7 changes: 7 additions & 0 deletions src/api/transactions/transactions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ std::string Transactions::types() {
return http_->get(paths::Transactions::types(this->host_).c_str());
}


/**/

std::string Transactions::fees() {
return http_->get(paths::Transactions::fees(this->host_).c_str());
}

/**/

std::string Transactions::search(
Expand Down
1 change: 1 addition & 0 deletions src/include/cpp-client/api/paths.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ struct Transactions {
static std::string get(Host& newHost, const char* const identifier);
static std::string allUnconfirmed(Host& newHost, const char* const query = DEFAULT_QUERY);
static std::string types(Host& newHost);
static std::string fees(Host& newHost);
static std::pair<std::string, std::string> search(Host& newHost,
const std::map<std::string, std::string>& bodyParameters,
const char* const query = DEFAULT_QUERY);
Expand Down
2 changes: 2 additions & 0 deletions src/include/cpp-client/api/transactions/transactions.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class ITransactions : public Base {
virtual std::string all(const char* const query) = 0;
virtual std::string allUnconfirmed(const char* const query) = 0;
virtual std::string types() = 0;
virtual std::string fees() = 0;
virtual std::string search(const std::map<std::string, std::string>& bodyParameters, const char* const query) = 0;
virtual std::string send(std::string& jsonTransaction) = 0;

Expand All @@ -47,6 +48,7 @@ class Transactions : public ITransactions {
std::string all(const char* const query) override;
std::string allUnconfirmed(const char* const query) override;
std::string types() override;
std::string fees() override;
std::string search(const std::map<std::string, std::string>& bodyParameters, const char* const query) override;
std::string send(std::string& jsonTransaction) override;
};
Expand Down
3 changes: 3 additions & 0 deletions test/api/paths.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ TEST(paths, test_transactions) { // NOLINT
const auto types = paths::Transactions::types(testHost);
ASSERT_STREQ("0.0.0.0:4003/api/transactions/types", types.c_str());

const auto fees = paths::Transactions::fees(testHost);
ASSERT_STREQ("0.0.0.0:4003/api/transactions/fees", fees.c_str());

const std::map<std::string, std::string> searchBody = {
{ "id", "dummy" },
{ "key", "value" }
Expand Down
30 changes: 30 additions & 0 deletions test/api/transactions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,36 @@ TEST(api, test_transaction_types) { // NOLINT

/**/

TEST(api, test_transaction_fees) { // NOLINT
Ark::Client::Connection<MockApi> connection(tIp, tPort);

const std::string expected_response = R"({
"data": {
"transfer": 10000000,
"secondSignature": 500000000,
"delegateRegistration": 2500000000,
"vote": 100000000,
"multiSignature": 500000000,
"ipfs": 0,
"timelockTransfer": 0,
"multiPayment": 0,
"delegateResignation": 2500000000
}
})";

EXPECT_CALL(connection.api.transactions, fees())
.Times(1)
.WillOnce(Return(expected_response));

const auto fees = connection.api.transactions.fees();

auto responseMatches = strcmp(expected_response.c_str(),
fees.c_str()) == 0;
ASSERT_TRUE(responseMatches);
}

/**/

TEST(api, test_transaction_unconfirmed) { // NOLINT
Ark::Client::Connection<MockApi> connection(tIp, tPort);

Expand Down
1 change: 1 addition & 0 deletions test/mocks/mock_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ class MockTransactions : public Ark::Client::api::ITransactions { // NOLINT
MOCK_METHOD1(all, std::string(const char* const));
MOCK_METHOD1(allUnconfirmed, std::string(const char* const));
MOCK_METHOD0(types, std::string());
MOCK_METHOD0(fees, std::string());
MOCK_METHOD2(search, std::string(const std::map<std::string, std::string>&, const char* const));
MOCK_METHOD1(send, std::string(std::string&));
};
Expand Down