fix: clang-tidy #138
Merged
fix: clang-tidy #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
|
@faustbrian This PR was just to get Tidy actually running at all. |
faustbrian
approved these changes
Oct 9, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears Clang-Tidy hasn't been working for a while now.
https://github.com/ArkEcosystem/cpp-client/runs/244421081#step:6:1
https://github.com/ArkEcosystem/cpp-client/runs/242002683#step:7:1
https://circleci.com/gh/ArkEcosystem/cpp-client/1551
The current CMake file incorrectly expects Clang-tidy v.6 since #116.
Since Tidy is part of the Clang-5 workflow, this PR changes the CMake config to use v.5
It also removes a non-working
-header-filtercall.The current behavior is identical to the default clang-tidy -header-filter default of .*.
Since it doesn't work as expected, there's no reason to have it.
Checklist
Additional Comments
Clang-Tidy tests may fail/take a long time because it is checking the entire CURL and GTest libraries and their tests.
This also happens without the
header-filteroption as seen here:A subsequent PR will address this issue.