Skip to content

feat: TX Send #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 30, 2019
Merged

feat: TX Send #64

merged 7 commits into from
Jan 30, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

Cpp-Client does not currently have a method for sending TX's.

This PR does the following:

  • adds Transactions::send() Paths method.
  • adds Transactions::send() method.
  • adds test for send Path method.
  • adds mock test for send Transactions method.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@sleepdefic1t
feat: TX Send
3774314 
- add 'Transactions::send()' method.
- add 'Transactions::send()' Paths method.
- add mock test for 'send' method.
- add test for 'send' Path method.
@codecov-io
Copy link

codecov-io commented Jan 26, 2019 •
edited
Loading

Codecov Report

Merging #64 into master will decrease coverage by 0.78%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   78.45%   77.67%   -0.79%     
==========================================
  Files          22       22              
  Lines         311      318       +7     
==========================================
+ Hits          244      247       +3     
- Misses         67       71       +4
Impacted Files Coverage Δ
...include/cpp-client/api/transactions/transactions.h 100% <ø> (ø) ⬆️
src/api/transactions/transactions.cpp 0% <0%> (ø) ⬆️
src/http/os/http.cpp 96.55% <100%> (-3.45%) ⬇️
src/api/paths.cpp 99.35% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f0e54...9eeaf2e. Read the comment docs.

@sleepdefic1t sleepdefic1t changed the title feat: TX Send [WIP] feat: TX Send Jan 26, 2019
@sleepdefic1t
Copy link
Contributor Author

This should be good to go now.

https://dexplorer.ark.io/transaction/34c8dda669ada82debca83a2900dc4293d3cc7e577b3440c7ee6963210231e77

any feedback or suggestions, @faustbrian @ciband ?

@sleepdefic1t sleepdefic1t changed the title [WIP] feat: TX Send feat: TX Send Jan 29, 2019
@faustbrian faustbrian merged commit 8aebc72 into ArkEcosystemArchive:master Jan 30, 2019
@sleepdefic1t sleepdefic1t mentioned this pull request Feb 5, 2019
Merged
12 tasks
@sleepdefic1t sleepdefic1t deleted the feat/tx-send branch February 15, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleepdefic1t @codecov-io @faustbrian