ESLint rule for user data lockfile

[bcotrim]

Related issues

• Appdata lockfile #1319

Proposed Changes

• Add ESLint rule to enforce lock and unlock when making changes to the app data file

Code errors examples:

Without changes	With changes to data	With changes, lock but no unlock	No error

Testing Instructions

• Code review and checking the ESLint behavior mentioned above

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[nightnei]

@bcotrim I am reviewing, but initially wanted to say that here is something weird:

[nightnei]

The general idea is awesome 👍
But I can't understand the usecase - in Frdrik's PR we are moving to using withUserDataWrite as the wrapper for saveUserData, so we won't use it directly anymore. And if somebody need to update appdata, they will definitely use only withUserDataWrite as the single option which includes lock/unlock out of the box, so we don't need eslint for this approach.
Could you please elaborate on the idea, maybe I am missing something, but can't understand how this linter will be used with Fredrik's changes.

[bcotrim]

Thanks for the review @nightnei

In Fredrik's PR you had some concerns about the readability and usage of the HOF, the ESLint rule allows us to not use that while ensuring we "force" developers to implement the lock/unlock in their code when they change the appdata.

[nightnei]

@bcotrim oh, I missed that it's a proposition of an alternative approach to HOF. The idea is really cool 👍