Translate OAuth links #1438
Merged
Translate OAuth links #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcotrim
approved these changes
May 26, 2025
There was a problem hiding this comment.
Code looks good and worked as described!
Unit tests are passing, although I see some errors:
I don't think they are related to this PR, but as we discussed we should aim to have our tests running without noise. I'll open a follow-up PR to fix it.
Edit: Actually it seems the errors logs are caused from this PR, at least I don't see them on trunk. On the CI for the latest trunk commit I don't see any issues, and on the CI for this PR I see it.
LGTM 👍
…translate-oauth-link
…translate-oauth-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm start.Cmd + ..login-signup-with-studio-locale.mp4
Pre-merge Checklist