Add TextTrimming #2459
Closed
Add TextTrimming #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Avalonia into feature/SkiaTextLayout
…/Avalonia into feature/SkiaTextLayout
…/Avalonia into feature/SkiaTextLayout
…/Avalonia into feature/SkiaTextLayout
…/Avalonia into feature/SkiaTextLayout
…/Avalonia into feature/SkiaTextLayout
|
Merged into Skia text layout PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This adds text trimming capabilities to FormattedText and therefore makes it possible to define TextTrimming for a TextBlock.
What is the current behavior?
Not supported.
What is the updated/expected behavior with this PR?
TextTrimming support for FormattedText
How was the solution implemented (if it's not obvious)?
CreateFormattedTextImpl has an additional parameter of type TextTrimming and therefore each platform needs to handle that additional parameter. Currently Direct2D1 is finished and Skia is missing the implementation.
Checklist
Fixed issues
#1897
#2452
Depends on
#1950