Upgrade WebDemo sample to .NET 8 #1059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Upgrades the WebDemo sample from .NET 6 to .NET 8, replaces connection-string auth with DefaultAzureCredential, and updates NuGet packages to their latest stable versions.
- Bumps target framework to net8.0 and adds
Azure.Identitysupport - Refactors
Program.csto use Azure App Configuration withDefaultAzureCredentialand dynamic refresh - Renames namespaces/files from
WebDemoNet6toWebDemoand updates solution/project definitions
Reviewed Changes
Copilot reviewed 80 out of 80 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/DotNetCore/WebDemo/WebDemo/WebDemo.csproj | Updated target framework to net8.0 and bumped package versions |
| examples/DotNetCore/WebDemo/WebDemo/Settings.cs | Renamed namespace to WebDemo |
| examples/DotNetCore/WebDemo/WebDemo/Program.cs | Integrated Azure App Configuration using DefaultAzureCredential and dynamic refresh |
| examples/DotNetCore/WebDemo/WebDemo/Pages/_ViewImports.cshtml | Updated Razor imports namespace |
| examples/DotNetCore/WebDemo/WebDemo/Pages/Shared/_Layout.cshtml | Corrected stylesheet reference and updated footer text |
| examples/DotNetCore/WebDemo/WebDemo/Pages/*.cshtml.cs | Updated page model namespaces |
| examples/DotNetCore/WebDemo/WebDemo.sln | Renamed solution/project entries and updated VS version & GUIDs |
Comments suppressed due to low confidence (3)
examples/DotNetCore/WebDemo/WebDemo/Program.cs:19
- The closing quote appears to be a curly double-quote which will cause a compile error; replace it with a straight
".
.Select("WebDemo:*”)
examples/DotNetCore/WebDemo/WebDemo/Program.cs:23
- [nitpick] There are no tests validating that dynamic configuration refresh works as expected; consider adding integration tests to cover the
AddAzureAppConfigurationrefresh behavior.
refreshOptions.RegisterAll();
examples/DotNetCore/WebDemo/WebDemo/Pages/Shared/_Layout.cshtml:49
- [nitpick] The privacy link was removed in this footer; re-adding a link to the privacy page helps maintain consistent navigation and accessibility.
© WebDemo for Azure App Configuration
|
|
||
| // Get the Azure App Configuration endpoint from environment or settings | ||
| string? appConfigEndpoint = builder.Configuration["AppConfig:Endpoint"] ?? | ||
| Environment.GetEnvironmentVariable("AppConfigEndpoint"); |
There was a problem hiding this comment.
[nitpick] Consider using the ASP.NET Core environment variable naming convention (AppConfig__Endpoint) so the configuration binder can automatically map nested settings.
Suggested change
| Environment.GetEnvironmentVariable("AppConfigEndpoint"); | |
| Environment.GetEnvironmentVariable("AppConfig__Endpoint"); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to GitHub Copilot agent :)