Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close underlying socket on dispose #526

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Close underlying socket on dispose #526

merged 1 commit into from
Aug 31, 2022

Conversation

johansme
Copy link
Contributor

@johansme johansme commented Aug 31, 2022 •
edited
Loading

Set the NetworkStream as owner of the underlying Socket, so that disposing the NetworkStream also disposes the Socket.

Fixes #525

@xinchen10 xinchen10 merged commit f0c3de2 into Azure:master Aug 31, 2022
@johansme johansme deleted the close-tls-socket branch September 1, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing AMQPS connection does not close TCP connection
2 participants
@johansme @xinchen10