Fix CNS logs bytes when printing HNS Endpoint

[Copilot]

This PR addresses the issue where CNS was directly logging HNS Endpoints with %+v, which resulted in printing byte arrays as raw bytes in the logs.

Changes made:

1. Updated the log statement in configureHostNCApipaEndpoint to print only relevant endpoint fields:

   // Old
   logger.Printf("[Azure CNS] Configured HostNCApipaEndpoint: %+v", endpoint)
   
   // New
   logger.Printf("[Azure CNS] Configured HostNCApipaEndpoint with ID: %s, Name: %s, Network: %s", endpoint.Id, endpoint.Name, endpoint.HostComputeNetwork)

2. Updated the error formatting in deleteEndpointByNameHnsV2:

   // Old
   return fmt.Errorf("Failed to delete endpoint: %+v. Error: %v", endpoint, err)
   
   // New
   return fmt.Errorf("Failed to delete endpoint: %s (%s). Error: %v", endpoint.Name, endpoint.Id, err)

3. Updated the log statement in deleteEndpointByNameHnsV2:

   // Old
   logger.Errorf("[Azure CNS] Successfully deleted endpoint: %+v", endpoint)
   
   // New
   logger.Errorf("[Azure CNS] Successfully deleted endpoint with ID: %s, Name: %s", endpoint.Id, endpoint.Name)

These changes ensure that only the relevant string fields (ID, Name, Network) are logged instead of the entire endpoint structure which contained byte arrays.

Fixes #3550.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[rbtr]

/azp run Azure Container Networking PR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull Request Overview

This PR refines CNS logging for HNS endpoints to prevent raw byte arrays from appearing in logs by outputting only key string fields.

• Updated the setup log in configureHostNCApipaEndpoint to include only ID, Name, and Network.
• Changed the error message in deleteEndpointByNameHnsV2 to reference endpoint Name and ID instead of the full struct.
• Adjusted the success log in deleteEndpointByNameHnsV2 to use ID and Name explicitly.

[Copilot]

Success messages should not use Errorf; consider using logger.Infof or logger.Printf to log successful deletion at the appropriate log level.

Suggested change

	logger.Errorf("[Azure CNS] Successfully deleted endpoint with ID: %s, Name: %s", endpoint.Id, endpoint.Name)
	logger.Infof("[Azure CNS] Successfully deleted endpoint with ID: %s, Name: %s", endpoint.Id, endpoint.Name)

[Copilot]

[nitpick] The field order here is Name then ID, which differs from other logs that list ID first. Consider switching to "ID: %s, Name: %s" for consistency across logs.

Suggested change

	return fmt.Errorf("Failed to delete endpoint: %s (%s). Error: %v", endpoint.Name, endpoint.Id, err)
	return fmt.Errorf("Failed to delete endpoint: ID: %s, Name: %s. Error: %v", endpoint.Id, endpoint.Name, err)

[pjohnst5]

@copilot , could you also print:

• endpoint.IpConfigurations
• endpoint.Dns
• endpoint.Routes
• endpoint.MacAddress
• endpoint.Flags
  ?

It would print something like this:

IpConfigurations:[{IpAddress:169.254.128.6 PrefixLength:17}]
Dns:{Domain: Search:[] ServerList:[] Options:[]}
Routes:[{NextHop:169.254.128.1 DestinationPrefix:0.0.0.0/0 Metric:0}]
MacAddress:00-15-5D-E7-DE-A0
Flags:0

[Copilot]

@copilot , could you also print:

• endpoint.IpConfigurations
• endpoint.Dns
  ...

I've added the requested fields to the log statements. Now all three logging locations will include:

• endpoint.IpConfigurations
• endpoint.Dns
• endpoint.Routes
• endpoint.MacAddress
• endpoint.Flags

These changes are in commit 526c7e7

[pjohnst5]

LGTM 🚀

[thatmattlong]

@copilot don't check in binaries, remove the file cns/service/service and update the .gitignore file so it doesn't get checked in again by anyone else

[Copilot]

@copilot don't check in binaries, remove the file cns/service/service and update the .gitignore file so it doesn't get checked in again by anyone else

I've removed the binary file at cns/service/service and updated the .gitignore to prevent it from being committed again in the future. The changes are in commit c32bbd0.

LGTM 🚀

Thank you for confirming the changes look good.

[pjohnst5]

Yeah good catch about the binaries, approved again

[thatmattlong]

/azp run Azure Container Networking PR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pjohnst5]

@copilot, can you fix the linting errors?

[Copilot]

@copilot, can you fix the linting errors?

I've fixed the linting errors by:

1. Splitting the long logging statements across multiple lines
2. Simplifying the error messages while preserving important endpoint details
3. Moving some detailed endpoint info to debug level logs

These changes are in commit 5169cb0.