-
Notifications
You must be signed in to change notification settings - Fork 246
chore: updating cilium nightly charts #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Cilium nightly charts from version 1.14 to 1.17 to fix pipeline failures caused by outdated charts. Key changes include:
- Adding new command-line flags (--enable-cilium-endpoint-slice and --ces-slice-mode) and updating security context in the deployment manifest.
- Modifying RBAC rules and configuration settings to support the updated chart version.
- Updating pipeline configurations to dynamically reference the Cilium Hubble version tag.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/integration/manifests/cilium/deployment.yaml | Adds new flags for endpoint slice support and updates container security context and tolerations. |
test/integration/manifests/cilium/daemonset.yaml | Updates labels and adds a volume mount for netns propagation. |
test/integration/manifests/cilium/cilium-nightly-operator/clusterrole.yaml | Adds new rules and labels to support additional Cilium resources. |
test/integration/manifests/cilium/cilium-nightly-config.yaml | Refreshes configuration settings and introduces new parameters for 1.17. |
test/integration/manifests/cilium/cilium-nightly-agent/{clusterrole,clusterrolebinding}.yaml | Updates labels and reorders permissions for cilium-nightly-agent. |
.pipelines/singletenancy/cilium-overlay* | Adjusts pipeline steps to export and use the dynamic Cilium Hubble version tag. |
Comments suppressed due to low confidence (2)
test/integration/manifests/cilium/deployment.yaml:42
- [nitpick] The flag '--ces-slice-mode' is somewhat ambiguous; consider renaming it to '--cilium-endpoint-slice-mode' for clarity.
- --ces-slice-mode=fcfs
test/integration/manifests/cilium/cilium-nightly-config.yaml:51
- [nitpick] The '+' character in the metrics value may lead to unexpected YAML parsing; consider quoting the value to ensure it is interpreted correctly.
metrics: +cilium_bpf_map_pressure
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Camryn Lee <31013536+camrynl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summarizing the conversation with camryn:
- Changes to the overlay pipeline can break the nightly pipeline since the PR check does not include running the cilium nightly pipeline and the nightly eventually calls into the overlay step template for example
- As long as we create a new cilium-config-hubble.yaml with each new version with updated charts, the v${DIR} should pull the correct version
- Eventually all nightly pipeline-specific files should be replaced with v${DIR} syntax where DIR is just the latest available version we have-- right now this PR just mostly copies the files in the cilium/v1.17 folder into the nightly pipeline files to update them
- The nightly pipeline builds against the latest cilium master so as of now v1.18, but as a best effort we use the charts/yamls from v1.17 as the v1.18 charts don't exist yet
- The only manual difference not generated from cilium helm is this change
- apiGroups:
- ""
resourceNames:
- cilium-config
resources:
- configmaps
verbs:
- list
- watch
which is a change required for cilium v1.18 to work.
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
nightly pipeline is experiencing some failures because the charts are too old
updating from 1.14 > 1.17 charts
Issue Fixed:
Requirements:
Notes: