Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QED input parameter check #89

Closed
gdiazlo opened this issue Mar 27, 2019 · 1 comment
Closed

QED input parameter check #89

gdiazlo opened this issue Mar 27, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gdiazlo
Copy link
Contributor

gdiazlo commented Mar 27, 2019

When setting up URLS from the command line we need to make sure those are well formed URLs, instead of passing random strings up to the libraries API.

This is quite annoying when we require to use http:// in and endpoint definition instead of hostname:port, and the program does not fail whatever you put in.

We must check all parameters properly.

@iknite iknite self-assigned this Apr 2, 2019
@iknite iknite added the bug Something isn't working label Apr 2, 2019
@iknite
Copy link
Contributor

iknite commented Apr 2, 2019

There is no out-of-the-box net/url.URL validator, not in https://golang.org/pkg/flag/ nor in https://godoc.org/github.com/spf13/pflag. we had to manually parse those params.

@aalda aalda added this to the v0.2-alpha milestone Apr 2, 2019
@aalda aalda modified the milestones: v0.2-alpha, v0.2-beta May 24, 2019
@jllucas jllucas self-assigned this Jun 11, 2019
suizman pushed a commit that referenced this issue Sep 30, 2019
Feat: Transform urlParse and urlParseNoSchemaRequired functions into variadics.

Closes #89


Former-commit-id: 4c74af2
suizman pushed a commit that referenced this issue Sep 30, 2019
Feat: Transform urlParse and urlParseNoSchemaRequired functions into variadics.

Closes #89


Former-commit-id: 9740b97 [formerly 4c74af2]
Former-commit-id: 81003d6
suizman pushed a commit that referenced this issue Sep 30, 2019
Feat: Transform urlParse and urlParseNoSchemaRequired functions into variadics.

Closes #89


Former-commit-id: 4c74af2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants