Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event hashing out of balloon internals #93

Closed
aalda opened this issue Apr 1, 2019 · 0 comments
Closed

Move event hashing out of balloon internals #93

aalda opened this issue Apr 1, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aalda
Copy link
Contributor

aalda commented Apr 1, 2019

Currently, inserted events get hashed in the Add method before inserting into both trees. This means that the raw event, whose size could be quite large compared with a 32B hash, is first stored in the WAL and then replicated to other nodes of the Raft cluster. We can avoid these unnecessary storage space and network traffic penalties by allowing Balloon to also accept event hashes instead of raw events in the Add method and hashing the events at the HTTP layer, before applying them to the WAL.

@aalda aalda added the enhancement New feature or request label Apr 1, 2019
@aalda aalda added this to the v0.2-beta milestone May 24, 2019
@jllucas jllucas self-assigned this Jun 7, 2019
suizman pushed a commit that referenced this issue Sep 30, 2019
suizman pushed a commit that referenced this issue Sep 30, 2019
Closes #93


Former-commit-id: 2631e02 [formerly b99d637]
Former-commit-id: 017b575
suizman pushed a commit that referenced this issue Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants