Cache rebuild #124
Merged
Cache rebuild #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalda
reviewed
May 23, 2019
| @@ -104,6 +105,7 @@ func NewRocksDBStoreOpts(opts *Options) (*RocksDBStore, error) { | |||
| cfOpts := []*rocksdb.Options{ | |||
| rocksdb.NewDefaultOptions(), | |||
| getHyperTableOpts(blockCache), | |||
| getHyperTableOpts(blockCache), // hyperCacheOpts table options | |||
There was a problem hiding this comment.
Open an issue to optimize this options
|
|
||
| } | ||
|
|
||
| func TestRebuildInterpretation(t *testing.T) { |
balloon/hyper/rebuild.go
Outdated
| ) | ||
|
|
||
| func pruneToRebuild(index, serializedBatch []byte, cacheHeightLimit uint16, batches batchLoader) *operationsStack { | ||
| func pruneToRebuildBulk(indexes [][]byte, cacheHeightLimit uint16, batches batchLoader) *operationsStack { |
balloon/balloon.go
Outdated
| func NewBalloon(store storage.Store, hasherF func() hashing.Hasher) (*Balloon, error) { | ||
|
|
||
| // create trees | ||
| historyTree := history.NewHistoryTree(hasherF, store, 300) | ||
| hyperTree := hyper.NewHyperTree(hasherF, store, cache.NewFreeCache(hyper.CacheSize)) | ||
| hasher := hasherF() | ||
| cacheHeightLimit := hasher.Len() - min(24, hasher.Len()/8*4) |
| key := pos.Bytes() | ||
| val := batch.Serialize() | ||
| c.Cache.Put(key, val) | ||
| if pos.Height == c.RecoveryHeight { |
There was a problem hiding this comment.
Consider to include this in the pruner as a new mutateOp
balloon/hyper/rebuild.go
Outdated
| ) | ||
|
|
||
| func pruneToRebuild(index, serializedBatch []byte, cacheHeightLimit uint16, batches batchLoader) *operationsStack { | ||
| func pruneToRebuildBulk(indexes [][]byte, cacheHeightLimit uint16, batches batchLoader) *operationsStack { |
There was a problem hiding this comment.
Rename function name to pruneToRebuild
added 11 commits
May 24, 2019 15:06
…ark code to measure its performance against the regular code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cache recovery strategy. From ~1200 to ~7 seconds adding one write per operation.
Co-authored-by: @aalda