Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot: keep inserting data when the QED leader changes #135

Merged
merged 8 commits into from
Jun 7, 2019
Merged

Riot: keep inserting data when the QED leader changes #135

merged 8 commits into from
Jun 7, 2019

Conversation

jllucas
Copy link

@jllucas jllucas commented Jun 4, 2019 •
edited
Loading

In short:

  • return error if primary is dead when asking for primary.
  • layout: refactor server start/stop/clean scripts and move to "deploy/local".
  • layout: move agents start/stop scripts to "deploy/local".

Jose Luis Lucas added 2 commits June 4, 2019 14:02
Feat: Improve RIOT client configuration
ac2eb0f 
Refactor: Move server/agents scripts to deploy/local
Ref: BBVA#119 and BBVA#99
Fix: raise new error when primary is dead.
10c8731 
Closes BBVA#99
@jllucas jllucas changed the title Riot leader changes Riot: keep inserting data when the leader changes Jun 4, 2019
@jllucas jllucas changed the title Riot: keep inserting data when the leader changes Riot: keep inserting data when the QED leader changes Jun 4, 2019
@jllucas jllucas requested review from aalda and gdiazlo June 6, 2019 14:16
iknite
iknite reviewed Jun 7, 2019
View reviewed changes
aalda
aalda approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@aalda aalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jllucas jllucas requested a review from aalda June 7, 2019 08:54
gdiazlo
gdiazlo suggested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the scripts

@jllucas jllucas removed the request for review from aalda June 7, 2019 08:54
suizman
suizman requested changes Jun 7, 2019
View reviewed changes
gdiazlo
gdiazlo approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

suizman
suizman approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@suizman suizman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jllucas jllucas merged commit ab51193 into BBVA:master Jun 7, 2019
@jllucas jllucas deleted the riot_leader_changes branch June 7, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iknite iknite iknite left review comments

@gdiazlo gdiazlo gdiazlo approved these changes

@aalda aalda aalda approved these changes

@suizman suizman suizman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jllucas @iknite @gdiazlo @aalda @suizman