Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS #66

Merged
merged 5 commits into from
Jan 10, 2019
Merged

TLS #66

merged 5 commits into from
Jan 10, 2019

Conversation

iknite
Copy link
Contributor

@iknite iknite commented Dec 22, 2018

Enable TLS configuration for QED servers.

  • Server is tls enabled by default (disabled by --insecure flag)
  • Client honors CApools unless --insecure is called.
  • Client requires http - https urls to function correctly.

@codecov-io
Copy link

Codecov Report

Merging #66 into master will decrease coverage by 0.25%.
The diff coverage is 69.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   68.74%   68.48%   -0.26%     
==========================================
  Files          48       49       +1     
  Lines        2761     2786      +25     
==========================================
+ Hits         1898     1908      +10     
- Misses        699      709      +10     
- Partials      164      169       +5
Impacted Files Coverage Δ
log/log.go 0% <ø> (ø) ⬆️
api/apihttp/apihttp.go 38.84% <ø> (ø) ⬆️
client/config.go 0% <0%> (ø)
tests/e2e/test_service.go 66.19% <50%> (-0.47%) ⬇️
client/client.go 56.91% <75%> (+1.77%) ⬆️
tests/e2e/setup.go 82.48% <80.95%> (-2.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc00cb...e82cfb8. Read the comment docs.

@iknite iknite merged commit bb28636 into BBVA:master Jan 10, 2019
@iknite iknite deleted the tls branch January 10, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants