fix:toSelectArray breaking change + document toArray change
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
changed the title
toSelectArray breaking change + document toArray changetoSelectArray breaking change + document toArray change
This was referenced Oct 15, 2020
|
Thanks @atymic - I learned from both of those mistakes - I appreciate you taking the time to lessen the impact of them. Sorry if it caused you bother with the apps that broke. |
|
No worries, I've done the same thing before 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
This PR is kind of a combination of a few issues. Mainly, it fixes the breaking change that was renaming
toSelectArray()on a minor version.This broke a few of my apps, and broke another client's app today.
There was also another breaking change (switching the behaviour of
toArray). I understand this was done to match the v1 behaviour, but I think this should have been a major version bump.I don't think it's a good idea to change this again, as it would be another breaking change, so I've added a readme section to show how you can restore that behaviour.
Changes
toSelectArraybreaking change by reinstating method (but marking is as deprecated)toArraybehaviour.Breaking changes
None.
Resolves #170